Skip to content

make sure that self.python_cmd is set before using it in PythonPackage.sanity_check_step#2447

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20210531093058_new_pr_UQhggTWDmv
May 31, 2021
Merged

make sure that self.python_cmd is set before using it in PythonPackage.sanity_check_step#2447
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20210531093058_new_pr_UQhggTWDmv

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 31, 2021

(created using eb --new-pr)
fixes #2446

@boegel boegel added the bug fix label May 31, 2021
@boegel boegel added this to the 4.4.0 milestone May 31, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 31, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS antiSMASH-5.1.2-foss-2019b-Python-3.7.4.eb
  • SUCCESS Python-3.9.5-GCCcore-10.3.0.eb
  • SUCCESS xarray-0.16.2-intel-2020b.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/f008bcabdacb5a6a1f4bee7ee2c0519d for a full test report.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 19a8427 into easybuilders:develop May 31, 2021
@boegel boegel deleted the 20210531093058_new_pr_UQhggTWDmv branch May 31, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crash when using --module-only with easyconfig using PythonBundle

2 participants