always add distinct_host_configuration=false to build command for TensorFlow#2459
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jun 8, 2021
Merged
always add distinct_host_configuration=false to build command for TensorFlow#2459boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
…ation This fixes a failure when using optarch=False due to missing CPATH and friends while compiling e.g. protobuf files.
Member
|
Without this change the installation of Reason is that the build environment for the host compilation is not properly set up unless |
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Member
|
I also tested this with easybuilders/easybuild-easyconfigs#12906 using |
boegel
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a failure when using optarch=False due to missing CPATH and friends while compiling e.g. protobuf files.
More info:
We pass env vars such as CPATH explicitely because Bazel clears the whole env. If you use
distinct_host_configuration=truethen bazel will have 2 envs: One for host compilation one for target compilation. We only pass stuff to the target env. Hence the host env is empty and the compiler can't find protobuf due to CPATH not being setSo optarch for TF is broken and likely always has been due to that flag. We can either remove the check which means optarch can now be used, although only for lower archs than the build node, or "fix" it by passing the env vars also to the Bazel host env.
But I think we don't support building for higher archs anyway, as e.g. all tests would fail to execute. Hence IMO we can remove the if and be done