Skip to content

add custom easyblock for torchvision#2467

Merged
smoors merged 2 commits intoeasybuilders:developfrom
Flamefire:20210610130334_new_pr_ClfeprqWFz
Jun 10, 2021
Merged

add custom easyblock for torchvision#2467
smoors merged 2 commits intoeasybuilders:developfrom
Flamefire:20210610130334_new_pr_ClfeprqWFz

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jun 10, 2021

(created using eb --new-pr)

This simplifies the ECs and fixes the "issue" that torchvision reports wrong versions, e.g. due to https://github.com/pytorch/vision/blob/v0.8.2/setup.py#L32

boegel
boegel previously requested changes Jun 10, 2021
Comment thread easybuild/easyblocks/t/torchvision.py Outdated
Comment thread easybuild/easyblocks/t/torchvision.py Outdated
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors dismissed boegel’s stale review June 10, 2021 20:16

requested changes addressed

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 10, 2021

Going in, thanks @Flamefire!

@smoors smoors merged commit da06591 into easybuilders:develop Jun 10, 2021
@Flamefire Flamefire deleted the 20210610130334_new_pr_ClfeprqWFz branch June 11, 2021 06:24
@boegel boegel changed the title new easyblock for torchvision add custom easyblock for torchvision Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants