change Bundle easyblock to also collect altroot and altversion in the module step so they are set when running --module-only#2485
Conversation
…e when running --module-only
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
wouldn't it make more sense to move to |
The |
|
(edit: |
|
For this easyblock it has no impact and the change you suggested works. However, it's hard to ensure that any easyblock that derives from this (and that we may not even know about) may not be leveraging to the init method and create an initialisation method that you can use both in the config and module methods. I did something similar recently for Tkinter (#2416) |
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Fixes the issue correctly ( |
(created using
eb --new-pr)fixes #2484
This maintains the current behaviour, but also checks for
altrootandaltversionin the module step if they are not already defined. This fixes the issue where they are not defined if we do a module only rebuild.