Use PYPI_SOURCE as the default for source_urls of extensions of Python easyconfigs#2493
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jun 28, 2021
Merged
Conversation
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) edit: tested with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to simplify Python ECs a bit and does basically the same as the PythonPackage itself does.
See easybuilders/easybuild-easyconfigs#13253
Why this didn't work before is because the PythonPackage (likely) gets the source_urls from the parent EC (in this case Python) and hence doesn't use the new default
This fixes this by defaulting the source-urls to PYPI_SOURCE