Skip to content

fix sanity check for later versions of Molpro#2499

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
rungitta:20210630153818_new_pr_eQmNMqaRiu
Jul 13, 2021
Merged

fix sanity check for later versions of Molpro#2499
migueldiascosta merged 1 commit intoeasybuilders:developfrom
rungitta:20210630153818_new_pr_eQmNMqaRiu

Conversation

@rungitta
Copy link
Copy Markdown

@rungitta rungitta commented Jun 30, 2021

(created using eb --new-pr)

@migueldiascosta migueldiascosta added this to the next release (4.4.2?) milestone Jul 13, 2021
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jul 13, 2021

lgtm - @rungitta can you submit a test report? i.e. running eb on local easyconfig(s) with --include-easyblocks-from-pr=2499 -u should upload the test reports to a gist and post a comment here

@rungitta
Copy link
Copy Markdown
Author

rungitta commented Jul 13, 2021

Test report by @rungitta

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 0 (1 easyconfigs in total)
bioint02.hpc.uio.no - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz (sandybridge), Python 3.6.8
See https://gist.github.com/a598d04c76c9f65f69eb04a56e41d6fa for a full test report.

@rungitta
Copy link
Copy Markdown
Author

rungitta commented Jul 13, 2021

Test report by @rungitta

Overview of tested easyconfigs (in order)

  • SUCCESS Molpro-mpp-2021.1.0.linux_x86_64_openmp.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bioint02.hpc.uio.no - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz (sandybridge), Python 3.6.8
See https://gist.github.com/c299c513b12505b0c20601f15a77aeee for a full test report.

migueldiascosta
migueldiascosta approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jul 13, 2021

Going in, thanks @rungitta!

@migueldiascosta migueldiascosta merged commit b0a7f95 into easybuilders:develop Jul 13, 2021
@boegel boegel changed the title fixed sanity check for later versions of molpro fixed sanity check for later versions of Molpro Aug 7, 2021
@boegel boegel changed the title fixed sanity check for later versions of Molpro fix sanity check for later versions of Molpro Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@rungitta @migueldiascosta