correctly check whether --with-ucx is used as OpenMPI configure option (taking into account --with-ucx=no)#2501
Conversation
| # this is required to avoid "error initializing an OpenFabrics device" warnings, | ||
| # see also https://www.open-mpi.org/faq/?category=all#ofa-device-error | ||
| if LooseVersion(self.version) >= LooseVersion('4.0.0') and '--with-ucx' in self.cfg['configopts']: | ||
| is_ucx_enabled = ('--with-ucx' in self.cfg['configopts'] and |
There was a problem hiding this comment.
Since we now enforce "--with-ucx=path" does this really work correctly?
There was a problem hiding this comment.
Yes. --with-ucx=path means enabled as does --with-ucx, but --with-ucx=no means the opposite
There was a problem hiding this comment.
I mainly mean, does '--with-ucx' in self.cfg['configopts'] return true if we have --with-ucx=path in configopts?
I can never remember how that "in" operator works...
a6b8b93 to
4f670be
Compare
|
Tests:
|
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
We want to disable verbs only when UCX is disabled. So also consider
--with-ucx=noas disabled (done in last #2500)