Skip to content

update sanity check in ESMF easyblock to take into account new binary names from version 8.1.0 onwards#2512

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
kilicomu:2481_ESMF_sanity_check_update
Jul 14, 2021
Merged

update sanity check in ESMF easyblock to take into account new binary names from version 8.1.0 onwards#2512
migueldiascosta merged 1 commit intoeasybuilders:developfrom
kilicomu:2481_ESMF_sanity_check_update

Conversation

@kilicomu
Copy link
Copy Markdown
Contributor

@kilicomu kilicomu commented Jul 12, 2021

ESMF command line utility names changed with v8.1 - this PR updates the sanity check to reflect the changes:

  • ESMF_Info => ESMF_PrintInfo
  • ESMF_InfoC => ESMF_PrintInfoC

Also, there were some command line utilities missing from the previously implemented sanity check, so this adds those:

  • ESMF_Regrid
  • ESMF_Scrip2Unstruct

Closes #2481

@migueldiascosta migueldiascosta added this to the next release (4.4.2?) milestone Jul 13, 2021
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jul 13, 2021

Test report by @migueldiascosta

Overview of tested easyconfigs (in order)

  • SUCCESS ESMF-8.0.1-foss-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/090b49a4167e5203a47571e6d0e683ea for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jul 13, 2021

lgtm - @kilicomu can you submit a test report with version 8.1? i.e. running eb on local easyconfig(s) with --include-easyblocks-from-pr=2512 -u should upload the test reports to a gist and post a comment here

(you may need to set up github integration, see https://docs.easybuild.io/en/latest/Integration_with_GitHub.html)

@kilicomu
Copy link
Copy Markdown
Contributor Author

kilicomu commented Jul 13, 2021

Test report by @kilicomu

Overview of tested easyconfigs (in order)

  • SUCCESS ESMF-8.1.1-intel-2021a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
login2.pri.viking.alces.network - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz, Python 2.7.15
See https://gist.github.com/4f2d7eb759c987307dbac99aad6461eb for a full test report.

@kilicomu
Copy link
Copy Markdown
Contributor Author

kilicomu commented Jul 13, 2021

@migueldiascosta Done - sorry about the first one; forgot to force the rebuild in my dev environment.

@migueldiascosta migueldiascosta changed the title Updates ESMF sanity check to 8.1 bin names update sanity check in ESMF easyblock to take into account new binary names from version 8.1.0 onwards Jul 14, 2021
migueldiascosta
migueldiascosta approved these changes Jul 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jul 14, 2021

Going in, thanks @kilicomu!

@migueldiascosta migueldiascosta merged commit 09c8b6c into easybuilders:develop Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

ESMF sanity check

2 participants

@kilicomu @migueldiascosta