code style fixes in OpenFOAM easyblock#253
Conversation
There was a problem hiding this comment.
Why call this function twice? It's also called at L56.
I think this hints at possibility for code factorization (ie. merge the two if-elif-else constructs or something of that type)
There was a problem hiding this comment.
Very good point, I overlooked this during porting/enhancing this easyblock. Fixed it, thanks.
|
I need to check the weird stuff in the OpenFOAM easyblock again... Using a sensible value I've forked of the MUMPS easyblocks that's ready to merge in, see #262. |
|
Jenkins: test this please |
|
hmm, new test passes, but for some reason jenkins isn't updating this new build status. |
|
It didn't update because I changed the permissions of the bot |
|
Jenkins: test this please |
1 similar comment
|
Jenkins: test this please |
|
Hmm, Jenkins fails to pick up the last commit, for some reason... |
…uild" This reverts commit 8bd2fba.
|
rebased this on develop to get it properly tested |
|
needs to be fully tested again, no time for it now, maybe for EB v1.13 |
|
v2.3.0 installed, seems to work OK. |
There was a problem hiding this comment.
this needs to be cleaned up... why didn't this work with run_cmd_qa!?
|
Retested with all existing (and new) OpenFOAM easyconfigs, fixed a couple of minor issues down the road. |
code style fixes in OpenFOAM easyblock
The OpenFOAM easyblock was touched during the build of OpenFOAM-1.6-ext, but nothing was changed except for code style fixes.
The MUMPS easyblock was ported from an old implementation, and further enhanced (to add support for building with GCC).