Merged
Conversation
When creating a new plugin with PSI4, the paths in the makefile are now correct.
Member
There was a problem hiding this comment.
please add a comment above this block to indicate why $PSI_OBJ_INSTALL_DIR and $PSI_SRC_INSTALL_DIR need to be set, since the build works fine without these
Member
Author
|
Ready for merge. |
Member
|
Thanks for the clarifying comments @wpoely86! |
Member
Author
There was a problem hiding this comment.
OK, this does not always work as expected. I shall try to fix it.
But more importantly: os.path.relpath is only available from python 2.6. I hope this doesn't case any problems...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the PSI_OBJ_INSTALL_DIR and PSI_SRC_INSTALL_DIR are set.