generate and install pkg-config files for OpenSSL wrapper#2549
generate and install pkg-config files for OpenSSL wrapper#2549boegel merged 6 commits intoeasybuilders:developfrom
Conversation
24a5610 to
1bb4be8
Compare
|
Test report by @Micket Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @Micket Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
That's an unexpected failure Edit: I think there is a (unrelated to this PR) issue with openssl_wrapper.py; it doesn't create the installdir as soon as other easyblocks, and it can trip up on the ghost-dir check when rebuilding: |
|
My tests are in easybuilders/easybuild-easyconfigs#13765 (comment) Please check the OpenSSL 1.0
OpenSSL 1.1
|
|
Test report by @Micket Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
CentOS7 (wrapped)Looks correct to me when comparing to host OS files. One minor difference to host pkgconfig files; the generated libssl pkgconfigfile includes |
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 2 (2 easyconfigs in total) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 2 (2 easyconfigs in total) |
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
OpenSSL 1.0
OpenSSL 1.1
|
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
This comment has been minimized.
This comment has been minimized.
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
On a CentOS 8 POWER9 system: OpenSSL 1.0
OpenSSL 1.1
|
|
On Fedora 33: OpenSSL 1.0Build from source, as expected, and the OpenSSL 1.1
|
|
@lexming On top of this OpenSSL with pkg-config files on CentOS 7 with Is that because this: should be: |
|
@boegel yes, indeed, those should use the names for the wrapper instead of those in the system. I'll fix it. |
This comment has been minimized.
This comment has been minimized.
|
@lexming the |
|
@boegel I can reproduce the issue, update: the duplicate linker paths that appear with our |
|
On a CentOS 7 Intel Skylake system with OpenSSL 1.0
OpenSSL 1.1
|
|
This looks OK to me now, and I was able to Rust on top on CentOS 7 (cfr. upcoming test report in easybuilders/easybuild-easyconfigs#13538). So, good to go I think? @lexming |
|
@boegel good to go on my side as well. I got a successful build of Rust with CentOS7 too (easybuilders/easybuild-easyconfigs#13538 (comment)). I just checked again on Fedora 33 and the |
Fixes #2525
The files for pkg-config have to be specifically generated for the wrapper because the
LibsandCflagsfound in certain system installations do not apply to the wrapper. For instance, OpenSSL 1.1 in CentOS 7 adds and extraopenssl11subdirectory to some paths.I avoided parsing the OpenSSL pkg-config files in the host system because they are not trivial to find:
So, this easyblock uses the
pkg-configcommand to extract as much information as possible from the system installation and the rest is hardcoded in the easyblock.update: this PR also makes the lookup of system libraries more reliable
openssl_libsinstead of only a first match.