Skip to content

convert version numbers to stricly numerical in Siesta easyblock#2553

Merged
smoors merged 4 commits intoeasybuilders:developfrom
akesandgren:20210820081942_new_pr_fsxTEQTmVL
Jan 5, 2022
Merged

convert version numbers to stricly numerical in Siesta easyblock#2553
smoors merged 4 commits intoeasybuilders:developfrom
akesandgren:20210820081942_new_pr_fsxTEQTmVL

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Aug 20, 2021

(created using eb --new-pr)

@akesandgren akesandgren added enhancement python3 Python 3 compatibility labels Aug 20, 2021
@akesandgren akesandgren added this to the next release (4.4.2?) milestone Aug 20, 2021
@akesandgren akesandgren linked an issue Aug 20, 2021 that may be closed by this pull request
Version match issue with Siesta EasyBlock #2551
Closed
@akesandgren akesandgren mentioned this pull request Aug 20, 2021
Merged
migueldiascosta
migueldiascosta reviewed Aug 20, 2021
View reviewed changes
Comment thread easybuild/easyblocks/s/siesta.py Outdated
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Aug 20, 2021

I suppose this will also solve easybuilders/easybuild-easyconfigs#13559

@akesandgren akesandgren mentioned this pull request Aug 20, 2021
Closed
@dithwick dithwick mentioned this pull request Aug 20, 2021
Merged
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Aug 21, 2021

Test report by @migueldiascosta

Overview of tested easyconfigs (in order)

Build succeeded for 10 out of 16 (9 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/d5843471d916b48844bdef1cac5e4272 for a full test report.

@boegel boegel changed the title siesta: convert version numbers to stricly numerical. convert version numbers to stricly numerical in Siesta easyblock Aug 22, 2021
@boegel boegel modified the milestones: 4.4.2, release after 4.4.2 Sep 1, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 4, 2021

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • **FAIL (unhandled exception: '<' not supported between instances of 'str' and 'int')Traceback (most recent call last):
    File "/p/project/cswmanage/jusuf/stages/Upstream/software/EasyBuild/20210904-dev/lib/python3.6/site-packages/easybuild/main.py", line 118, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
    File "/p/project/cswmanage/jusuf/stages/Upstream/software/EasyBuild/20210904-dev/lib/python3.6/site-packages/easybuild/framework/easyblock.py", line 3713, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
    File "/p/project/cswmanage/jusuf/stages/Upstream/software/EasyBuild/20210904-dev/lib/python3.6/site-packages/easybuild/framework/easyblock.py", line 3601, in run_all_steps
    self.run_step(step_name, step_methods)
    File "/p/project/cswmanage/jusuf/stages/Upstream/software/EasyBuild/20210904-dev/lib/python3.6/site-packages/easybuild/framework/easyblock.py", line 3454, in run_step
    step_method(self)()
    File "/tmp/eb-qiu1zbp7/included-easyblocks-f7nse690/easybuild/easyblocks/siesta.py", line 129, in configure_step
    if loose_ver < LooseVersion('4.1.0.2.2'):
    File "/usr/lib64/python3.6/distutils/version.py", line 52, in lt
    c = self._cmp(other)
    File "/usr/lib64/python3.6/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
    TypeError: '<' not supported between instances of 'str' and 'int'
    ** Siesta-4.1-MaX-1.0-intel-2019b-PEXSI.eb

Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsfl03.jusuf - Linux centos linux 7.9.2009, x86_64, AMD EPYC 7742 64-Core Processor, Python 3.6.8
See https://gist.github.com/0ee75adf9d8f32e730f61624f3d61962 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 4, 2021

Fails for Siesta-4.1-MaX-1.0-intel-2019b-PEXSI.eb with

  File "/tmp/eb-qiu1zbp7/included-easyblocks-f7nse690/easybuild/easyblocks/siesta.py", line 129, in configure_step
    if loose_ver < LooseVersion('4.1.0.2.2'):
  File "/usr/lib64/python3.6/distutils/version.py", line 52, in __lt__
    c = self._cmp(other)
  File "/usr/lib64/python3.6/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
TypeError: '<' not supported between instances of 'str' and 'int

@boegel boegel modified the milestones: 4.5.1, release after 4.5.1 Dec 7, 2021
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 31, 2021

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS Siesta-4.1-MaX-1.0-intel-2019b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/6a4a4cb766cc13e1f93b529b9bdeeb9c for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 4, 2022

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS Siesta-4.1-b4-foss-2018b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node308.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/560cbf452ce5b0a92c87acbf3ff5f241 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 5, 2022

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS Siesta-4.1-5-intel-2019b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node357.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/eccba20391b8437620cf5412f60bb8e5 for a full test report.

smoors
smoors approved these changes Jan 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 5, 2022

Going in, thanks @akesandgren!

@smoors smoors merged commit f615a1b into easybuilders:develop Jan 5, 2022
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jan 6, 2022

Test report by @migueldiascosta

Overview of tested easyconfigs (in order)

Build succeeded for 8 out of 12 (9 easyconfigs in total)
c2dhpc - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/cf5b713447d7b856d35b301cf2f9c67c for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jan 6, 2022

the failures above are only because of the license for intel/2018, but Siesta-4.1-b4 builds with foss/2018 and other versions of Siesta build with the versions of intel that are already installed, so there shouldn't be any problem

@akesandgren akesandgren deleted the 20210820081942_new_pr_fsxTEQTmVL branch January 10, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta left review comments

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix python3 Python 3 compatibility

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

Version match issue with Siesta EasyBlock

5 participants

@akesandgren @migueldiascosta @SebastianAchilles @smoors @boegel