Skip to content

unset $EASYBUILD_* environment variables when running sanity check in EasyBuildMeta easyblock + also unset $MODULES_LMCONFLICT to avoid conflict when loading EasyBuild module#2568

Merged
branfosj merged 3 commits intoeasybuilders:developfrom
boegel:20210907140417_new_pr_easybuildmeta
Sep 8, 2021
Merged

unset $EASYBUILD_* environment variables when running sanity check in EasyBuildMeta easyblock + also unset $MODULES_LMCONFLICT to avoid conflict when loading EasyBuild module#2568
branfosj merged 3 commits intoeasybuilders:developfrom
boegel:20210907140417_new_pr_easybuildmeta

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 7, 2021

(created using eb --new-pr)
prevents problems like:

Sanity check failed: sanity check command eb --version exited with code 1 (output: ERROR: Failed to parse configuration options: 'Found 1 environment variable(s) that are prefixed with EASYBUILD but do not match valid option(s): EASYBUILD_ACCEPT_EULA_FOR'

@boegel boegel added the bug fix label Sep 7, 2021
@boegel boegel added this to the next release (4.4.3?) milestone Sep 7, 2021
@boegel
also unset $MODULES_LMCONFLICT (Environment Modules 4.x) and $__MODUL…
f90b62b 
…ES_LMCONFLICT (Environment Modules 5.x) if defined to avoid failing 'module load EasyBuild' command during sanity check for EasyBuild
@boegel boegel changed the title unset $EASYBUILD_* environment variables when running sanity check in EasyBuildMeta easyblock unset $EASYBUILD_* environment variables when running sanity check in EasyBuildMeta easyblock + also unset $MODULES_LMCONFLICT to avoid conflict when loading EasyBuild module Sep 8, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 8, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.4.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3118.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/dae9270f188d576a1b9386337d066f66 for a full test report.

@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 8, 2021

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.4.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/49e8b6f71675aec83778b3c34a05f87b for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 8, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.4.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2642.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a4c7a8bf013e648aa33a353bab613992 for a full test report.

branfosj
branfosj approved these changes Sep 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Sep 8, 2021

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.4.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/83dc0630c3d0d5e8378942d7ccb8d323 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Sep 8, 2021

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.4.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz, Python 3.6.8
See https://gist.github.com/cbfa320708b677692fb1917acb43ab37 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Sep 8, 2021 •
edited
Loading

My tests were with EB versions:

  • latest develop
  • 4.3.3 (Feb 2021)
  • 4.2.1 (May 2020) - this test report is missing, but it was successful

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Sep 8, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit e9c2ea2 into easybuilders:develop Sep 8, 2021
@boegel boegel deleted the 20210907140417_new_pr_easybuildmeta branch September 8, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @branfosj