Skip to content

fix subdir path in VTune easyblock for 2021.x versions + add sanity check command#2576

Merged
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:20210914171758_new_pr_vtune
Sep 14, 2021
Merged

fix subdir path in VTune easyblock for 2021.x versions + add sanity check command#2576
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:20210914171758_new_pr_vtune

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Sep 14, 2021

(created using eb --new-pr)

@akesandgren
Update subdir path in VTune easyblock for 2021.x versions. Drop no lo…
03a789d 
…nger needed special handling of sanity check for version >= 2021.
@akesandgren akesandgren added this to the 4.x milestone Sep 14, 2021
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 14, 2021

The previous change to vtune.py only changed the sanity check, but what is really needed is to change subdir. This way sanity check doesn't need to be changed for 2021.x and we get a correctly set PATH

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 14, 2021

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS VTune-2021.6.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/0fa9bcdb533b04c9181bae29cdf39f3b for a full test report.

@akesandgren akesandgren requested a review from boegel September 14, 2021 15:27
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2021

@akesandgren Can we add a custom sanity check command too (using --version or --help on one of the tools)?
If it were there, we wouldn't have overlooked the $PATH issue...

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 14, 2021 •
edited
Loading

Yeah, vtune --version should suffice.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 14, 2021

@boegel Can you run a test for some older VTune? My container doesn't have the required OS packages for the older versions... preferably a pre 2020 version...

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Sep 14, 2021

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS VTune-2021.6.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/368ea32ffb96dbc5b4c01f8453cd1f14 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 14, 2021

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS VTune-2021.6.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/1f8874e21e90fff4db6e65abb09fdbda for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Sep 14, 2021

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS VTune-2019_update5.eb
  • SUCCESS VTune-2020_update3.eb
  • SUCCESS VTune-2021.6.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jrlogin01.jureca - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/baf8f48d975c6fcf989285b619aab1d9 for a full test report.

@boegel boegel changed the title Update subdir path in VTune easyblock for 2021.x versions. Update subdir path in VTune easyblock for 2021.x versions Sep 14, 2021
@boegel boegel changed the title Update subdir path in VTune easyblock for 2021.x versions fix subdir path in VTune easyblock for 2021.x versions + add sanity check command Sep 14, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS VTune-2013_update10.eb
  • SUCCESS VTune-2017.eb
  • SUCCESS VTune-2019_update5.eb
  • SUCCESS VTune-2020_update3.eb
  • SUCCESS VTune-2021.6.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node2695.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/111a29221006431d2631db768919bd15 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.4.3?) Sep 14, 2021
boegel
boegel approved these changes Sep 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 20548ad into easybuilders:develop Sep 14, 2021
@akesandgren akesandgren deleted the 20210914171758_new_pr_vtune branch September 15, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @boegel @SebastianAchilles