Skip to content

add support for specifying subdirectory for target installation directory in CMakeMake#2579

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20210916123834_new_pr_cmakemake
Sep 16, 2021
Merged

add support for specifying subdirectory for target installation directory in CMakeMake#2579
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20210916123834_new_pr_cmakemake

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 16, 2021

(created using eb --new-pr)

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 16, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Z3-4.8.10-GCCcore-10.2.0.eb
  • SUCCESS libjpeg-turbo-2.0.6-GCCcore-11.2.0.eb
  • SUCCESS DIAMOND-2.0.4-GCC-9.3.0.eb
  • SUCCESS Eigen-3.3.7.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2606.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/58bbfcafe49a56a7f8d85a41c1b462ee for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 74a385d into easybuilders:develop Sep 16, 2021
@boegel boegel deleted the 20210916123834_new_pr_cmakemake branch September 16, 2021 17:43
@boegel boegel changed the title add support for specifying subdirectory for target installation directory in CMakMake add support for specifying subdirectory for target installation directory in CMakeMake Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants