Skip to content

fix support for recent imkl version in numexpr easyblock#2606

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20211022183211_new_pr_numexpr
Oct 26, 2021
Merged

fix support for recent imkl version in numexpr easyblock#2606
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20211022183211_new_pr_numexpr

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Oct 22, 2021

(created using eb --new-pr)

@akesandgren akesandgren added this to the 4.5.0 (next release) milestone Oct 22, 2021
This was referenced Oct 22, 2021
Merged
Merged
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 23, 2021

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS numexpr-2.7.1-intel-2019b-Python-2.7.16.eb
  • SUCCESS numexpr-2.7.1-intel-2020a-Python-3.8.2.eb
  • SUCCESS numexpr-2.7.1-foss-2020a-Python-3.8.2.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/41ec03baaa6ddd28ebdc8247e4834395 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 23, 2021

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS numexpr-2.6.5-fosscuda-2018b-Python-3.6.6.eb
  • SUCCESS numexpr-2.7.1-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS SciPy-bundle-2020.11-intelcuda-2020b.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
bber0501u03b.bb2.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2baf1db0721e8b102afecd8792f5b82f for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 23, 2021

My test reports used easybuilders/easybuild-framework#3866

@boegel boegel changed the title Fix numexpr handling of newer MKL versions. fix support for recent imkl version in numexpr easyblock Oct 23, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 25, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS numexpr-2.6.4-foss-2018a-Python-3.6.4.eb
  • SUCCESS numexpr-2.6.5-intel-2018b-Python-2.7.15.eb
  • SUCCESS numexpr-2.6.4-foss-2016a-Python-3.5.1.eb
  • SUCCESS SciPy-bundle-2020.11-foss-2020b-Python-2.7.18.eb
  • SUCCESS SciPy-bundle-2020.11-foss-2020b.eb
  • SUCCESS SciPy-bundle-2020.11-fosscuda-2020b.eb
  • SUCCESS SciPy-bundle-2020.11-intel-2020b.eb
  • SUCCESS SciPy-bundle-2021.05-foss-2021a.eb
  • SUCCESS SciPy-bundle-2021.10-foss-2021.07.eb
  • SUCCESS numexpr-2.5.2-intel-2016a-Python-2.7.11.eb
  • SUCCESS numexpr-2.6.1-foss-2016b-Python-2.7.12.eb
  • SUCCESS numexpr-2.7.1-intel-2020a-Python-3.8.2.eb
  • SUCCESS numexpr-2.7.1-intel-2019b-Python-2.7.16.eb
  • SUCCESS numexpr-2.7.1-foss-2020a-Python-3.8.2.eb
  • SUCCESS CUDA-11.1.1-iccifort-2020.4.304.eb
  • SUCCESS iccifortcuda-2020b.eb
  • SUCCESS impi-2019.9.304-iccifortcuda-2020b.eb
  • SUCCESS iimpic-2020b.eb
  • SUCCESS imkl-2020.4.304-iimpic-2020b.eb
  • SUCCESS intelcuda-2020b.eb
  • SUCCESS SciPy-bundle-2020.11-intelcuda-2020b.eb

Build succeeded for 21 out of 21 (15 easyconfigs in total)
node2636.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/9d9c5850c2864043baabe229b4c01a30 for a full test report.

boegel
boegel approved these changes Oct 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 26, 2021

Also tested with easybuilders/easybuild-easyconfigs#12964, so good to go, thanks for the fix @akesandgren!

@boegel boegel merged commit 4f38965 into easybuilders:develop Oct 26, 2021
@akesandgren akesandgren deleted the 20211022183211_new_pr_numexpr branch October 26, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @branfosj @boegel