Skip to content

derive custom easyblock from MotionCor2 from PackedBinary instead of EasyBlock#2607

Merged
boegel merged 1 commit intoeasybuilders:developfrom
MaximeMoge:change_motioncor2_into_packedbinary
Oct 27, 2021
Merged

derive custom easyblock from MotionCor2 from PackedBinary instead of EasyBlock#2607
boegel merged 1 commit intoeasybuilders:developfrom
MaximeMoge:change_motioncor2_into_packedbinary

Conversation

@MaximeMoge
Copy link
Copy Markdown

@MaximeMoge MaximeMoge commented Oct 25, 2021

Using PackedBinary for MotionCor2.
This is a follow-up to the discussion in #2541, and in particular comment #2541 (comment)

@boegel boegel changed the title change the easyblock class for MotionCor2 from EasyBlock into PackedB… change the easyblock class for MotionCor2 from EasyBlock into PackedBinary Oct 27, 2021
@boegel boegel added the change label Oct 27, 2021
@boegel boegel added this to the 4.5.0 (next release) milestone Oct 27, 2021
@boegel boegel changed the title change the easyblock class for MotionCor2 from EasyBlock into PackedBinary derive custom easyblock from MotionCor2 from PackedBinary instead of EasyBlock Oct 27, 2021
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 27, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MotionCor2-1.2.6-GCCcore-8.2.0.eb
  • SUCCESS MotionCor2-1.3.1-GCCcore-8.3.0.eb
  • SUCCESS MotionCor2-1.3.2-GCCcore-8.3.0.eb
  • SUCCESS MotionCor2-1.4.2-GCCcore-10.2.0.eb
  • SUCCESS MotionCor2-1.4.4-GCCcore-10.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node2602.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/15e349e592b13d81e33b6b6abfa018d8 for a full test report.

@boegel boegel merged commit 92b2226 into easybuilders:develop Oct 27, 2021
@akesandgren
Copy link
Copy Markdown
Contributor

Oh, was that all it needed? Thanks for looking into and fixing this @MaximeMoge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants