Skip to content

avoid patching binary files + other enhancements for MUMmer easyblock#2630

Merged
boegel merged 5 commits intoeasybuilders:developfrom
deniskristak:20211206165730_new_pr_mummer
Dec 7, 2021
Merged

avoid patching binary files + other enhancements for MUMmer easyblock#2630
boegel merged 5 commits intoeasybuilders:developfrom
deniskristak:20211206165730_new_pr_mummer

Conversation

@deniskristak
Copy link
Copy Markdown
Contributor

@deniskristak deniskristak commented Dec 6, 2021

(created using eb --new-pr)

edit: fixes #2629

@deniskristak
Copy link
Copy Markdown
Contributor Author

@boegel can be reviewed

Comment thread easybuild/easyblocks/m/mummer.py Outdated
@boegel boegel changed the title work on easyblocks mummer issue #2629 avoid patching binary files + other enhancements for MUMmer easyblock Dec 7, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Dec 7, 2021
Comment thread easybuild/easyblocks/m/mummer.py Outdated
support from universal CFLAGS

Co-authored-by: Kenneth Hoste <[email protected]>
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MUMmer-3.23-foss-2016b.eb
  • SUCCESS MUMmer-3.23-GCCcore-9.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2613.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/f4e263797c50eb4d1f4346caa0af00ef for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MUMmer-3.23-foss-2016b.eb
  • SUCCESS MUMmer-3.23-GCCcore-9.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2613.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4bb145fbd71ee26afaea4390d41494ee for a full test report.

@boegel boegel merged commit 889e2ff into easybuilders:develop Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MUMmer easyblock corrupts binaries by running apply_regex_substitutions

3 participants