add option to not copy the license file for Gurobi#2639
add option to not copy the license file for Gurobi#2639wpoely86 merged 4 commits intoeasybuilders:developfrom
Conversation
|
Test report by @smoors Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
| """Easyblock constructor, define custom class variables specific to Gurobi.""" | ||
| super(EB_Gurobi, self).__init__(*args, **kwargs) | ||
|
|
||
| self.license_file = 'UNKNOWN' |
There was a problem hiding this comment.
why not None? You run a check for is None below?
There was a problem hiding this comment.
it doesn't matter what the value is here, because it is always reassigned to self.cfg['license_file'].
it's not strictly necessary to initialize it here, but github tests complain if I don't.
I just used 'UNKNOWN' because that's what the other easyblocks do.
There was a problem hiding this comment.
Actually, it does matter: if --module-only is used, we'll now end up with UNKNOWN in the module file, because install_step is never run.
You can actually use self.cfg['license_file'] already here, because the easyconfig file is already parsed when the easyblock is initialized (the parsed easyconfig is an input for the easyblock initialization):
self.license_file = self.cfg['license_file']There was a problem hiding this comment.
@boegel
ah good point, I'll fix it.
then the pgi.py easyblock has the same problem?
|
Test report by @smoors Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
(created using
eb --new-pr)rationale: with multiple Gurobi installations using the same license file, defined by GRB_LICENSE_FILE, only one file needs to be updated.