add support for enabling sanity checks for specific components in the Bundle easyblock#2649
Conversation
Co-authored-by: Kenneth Hoste <[email protected]>
| cnt = len(self.comp_cfgs_sanity_check) | ||
| for idx, comp in enumerate(self.comp_cfgs_sanity_check): | ||
| comp_name, comp_ver = comp.cfg['name'], comp.cfg['version'] | ||
| print_msg("sanity checking bundle component %s v%s (%i/%i)...", comp_name, comp_ver, idx + 1, cnt) |
There was a problem hiding this comment.
I wonder if the (x/y) is worthwile adding, since if not all components are being sanity checked, this may cause confusion why the total count mentioned here is lower than the total number of components?
There was a problem hiding this comment.
I felt it was nice to have an idea of the overall progress, but since the sanity checks shouldn't take overly long I'm happy to remove it, if it's likely to cause more confusion than it helps
There was a problem hiding this comment.
No strong objection, let's proceed as is, it's easy enough to change later if it's indeed confusing people.
Co-authored-by: Kenneth Hoste <[email protected]>
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 11 out of 11 (11 easyconfigs in total) |
(created using
eb --new-pr)Adds support to run sanity checks for specific bundle components. Useful for e.g. easyconfig PR #14591