Skip to content

minor code cleanup in numexpr easyblock#2679

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20220214180756_new_pr_numexpr
Feb 15, 2022
Merged

minor code cleanup in numexpr easyblock#2679
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20220214180756_new_pr_numexpr

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 14, 2022

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 14, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS numexpr-2.7.1-intel-2020a-Python-3.8.2.eb
  • SUCCESS SciPy-bundle-2021.10-foss-2021b.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2620.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/db7a573cbde949639400d620d61cd8ba for a full test report.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit b3e808f into easybuilders:develop Feb 15, 2022
@boegel boegel deleted the 20220214180756_new_pr_numexpr branch February 15, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants