Skip to content

enhance Clang easyblock to support also installing Python bindings#2721

Merged
branfosj merged 5 commits intoeasybuilders:developfrom
ComputeCanada:clang_python_bindings
May 25, 2022
Merged

enhance Clang easyblock to support also installing Python bindings#2721
branfosj merged 5 commits intoeasybuilders:developfrom
ComputeCanada:clang_python_bindings

Conversation

@mboisson
Copy link
Copy Markdown
Contributor

@mboisson mboisson commented May 11, 2022

No description provided.

@boegel boegel changed the title added support for python bindings for clang enhance Clang easyblock to support also installing Python bindings May 11, 2022
@boegel boegel added this to the 4.x milestone May 11, 2022
branfosj
branfosj reviewed May 21, 2022
View reviewed changes
Comment thread easybuild/easyblocks/c/clang.py Outdated
@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 25, 2022 •
edited
Loading

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS elfutils-0.185-GCCcore-10.3.0.eb
  • SUCCESS Z3-4.8.11-GCCcore-10.3.0.eb
  • SUCCESS Clang-12.0.1-GCCcore-10.3.0.eb

Build succeeded for 3 out of 3 (1 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/94e695a72d227e038dc70f686d220daa for a full test report.

edit: built with an easyconfig with python_bindings = True and Python as a dependency (rather than build dependency).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 25, 2022 •
edited
Loading

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-8.0.0-GCCcore-8.2.0.eb
  • SUCCESS Clang-13.0.1-GCCcore-11.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/03e3b9754b7552864fd8bf847fcb9a30 for a full test report.

edit: both built with current versions of easyconfigs - i.e. not enabling Python bindings

@branfosj branfosj modified the milestones: 4.x, next release (4.5.5?) May 25, 2022
branfosj
branfosj approved these changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 25, 2022

Going in, thanks @mboisson!

@branfosj branfosj merged commit 7cf55a7 into easybuilders:develop May 25, 2022
@boegel boegel mentioned this pull request May 30, 2022
Merged
@mboisson mboisson deleted the clang_python_bindings branch May 30, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mboisson @branfosj @boegel