Skip to content

add support to ConfigureMake for tweaking (first part of) test command via 'test_cmd'#2726

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:configuremake_test_cmd
May 31, 2022
Merged

add support to ConfigureMake for tweaking (first part of) test command via 'test_cmd'#2726
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:configuremake_test_cmd

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 31, 2022

No description provided.

@boegel boegel added this to the 4.5.5 milestone May 31, 2022
Micket
Micket approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented May 31, 2022

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS LZO-2.10-GCCcore-11.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 3.6.8
See https://gist.github.com/368871719e7f00fa3787aaa8b0291342 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented May 31, 2022 •
edited
Loading

@boegel Interestingly, if I use this (with test_cmd = 'echo' in the ec) it works just fine:

== testing...
  >> running command:
        [started at: 2022-05-31 09:46:40]
        [working dir: /home/ocaisa/.local/easybuild/build/LZO/2.10/GCCcore-11.2.0/lzo-2.10]
        [output logged in /tmp/eb-0ij5uqg8/easybuild-run_cmd-0_0up1wg.log]
        echo test
  >> command completed: exit 0, ran in < 1s

but if I do the same thing in extended dry run mode, it reports the default:

[test_step method]
  >> running command:
	[started at: 2022-05-31 09:48:56]
	[working dir: /tmp/eb-baidba6y/__ROOT__/home/ocaisa/.local/easybuild/build/LZO/2.10/GCCcore-11.2.0/LZO-2.10]
	[output logged in /tmp/eb-baidba6y/easybuild-run_cmd-xlokny0u.log]
	make test
  running command "make test"
  (in /home/ocaisa/.local/easybuild/build/LZO/2.10/GCCcore-11.2.0/LZO-2.10)

That's because the easyblock git patch is never actually applied, which I think would perhaps not be expected. I'll open an issue for that.

@ocaisa ocaisa mentioned this pull request May 31, 2022
Open
@ocaisa ocaisa merged commit 39fedbb into easybuilders:develop May 31, 2022
@boegel boegel deleted the configuremake_test_cmd branch May 31, 2022 14:51
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 31, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS VEP-105-GCC-11.2.0.eb
  • SUCCESS BioPerl-1.7.8-GCCcore-10.3.0.eb
  • SUCCESS zlib-1.2.11-GCCcore-9.3.0.eb
  • SUCCESS wget-1.21.1-GCCcore-10.3.0.eb
  • SUCCESS protobuf-2.5.0-GCCcore-10.2.0.eb
  • SUCCESS OSU-Micro-Benchmarks-5.6.3-iimpi-2020b.eb
  • SUCCESS MPFR-4.1.0-GCCcore-10.3.0.eb
  • SUCCESS x265-3.5-GCCcore-11.2.0.eb
  • SUCCESS SeqAn-2.4.0-GCCcore-10.2.0.eb
  • SUCCESS protobuf-3.17.3-GCCcore-10.3.0.eb
  • SUCCESS openCARP-8.2-foss-2021a.eb

Build succeeded for 11 out of 11 (11 easyconfigs in total)
node3141.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/bac36269febec41849dc1b07e73fdb93 for a full test report.

Micket
Micket reviewed Jun 6, 2022
View reviewed changes
Comment thread easybuild/easyblocks/generic/configuremake.py
@@ -348,7 +350,12 @@ def test_step(self):
"""

if self.cfg['runtest']:
Copy link
Copy Markdown
Contributor

@Micket Micket Jun 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Hm, i just realized this leads the situation that you need to specify something in the runtest part, else testing won't be considered.
Perhaps change this to

if self.cfg['runtest'] or self.cfd['test_cmd'] != DEFAULT_TEST_CMD:

Otherwise you'd have to do possibly silly things:

test_cmd = './tests.sh'
runtest = ' ' # only to trigger the tests

or

test_cmd = 'ctest'
runtest = '-j'  # add one flag here or something to make it actually run.

Copy link
Copy Markdown
Member Author

@boegel boegel Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket Makes sense, please open a PR for that ASAP, maybe (just maybe) we can still include this into EasyBuild v4.5.5

Copy link
Copy Markdown
Member Author

@boegel boegel Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followed up in #2737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @ocaisa @Micket