Skip to content

fix issues with running NWChem test cases, fail early in case broken symlink is present#275

Merged
boegel merged 9 commits intoeasybuilders:v1.8.xfrom
boegel:fix_nwchem
Oct 13, 2013
Merged

fix issues with running NWChem test cases, fail early in case broken symlink is present#275
boegel merged 9 commits intoeasybuilders:v1.8.xfrom
boegel:fix_nwchem

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 10, 2013

No description provided.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 11, 2013

Fully tested, works like a charm now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your error message will have to be a bit more descriptive: when user is useing nwchem, and wants to try out a new version, it will trigger this error. i'd add something like Please temporarily rename the self.home_nwchemrc during nwchem installation. It can be restored later for nwchem use.
Btw, we should cleanup the self.home_nwchemrc after installation (and to be on the safe side, also their i'd check if samefile(self.home_nwchemrc, self.local_nwchemrc)), so a user can simple rename the original home_nwchemrc

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good suggestions, I'll take care of it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing, I realized that cleaning up the ~/.nwchemrc symlink is not an option, since it may cause the test cases of other NWChem builds running at the same time to fail...

I've added a post message instead that reminds the user to clean up the ~/.nwchemrc symlink once all NWChem builds are complete. This will be a warning which is shown at the very of the output.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow... this explains why I have been with the impression of so many installers having issues run in parallel; but then work fine if rerun again in isolation! I had assumed some common file collision, but an rm -rf on a dir like /tmp/NCBI* etc could also explain such cases...

if you agree, it would be nice to have the option to de-parallelize builds of the same package, because they are prone to bring up failure modes that the developers did not consider in their installation mechanisms...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you deparallellize (open an issue for that btw, it will be forgotten if we keep the discussion ongoing in here).

Lock files are not a good option imho, because we deal with shared filesystems very often...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 13, 2013

Rested, works like a charm now, so merging in.

boegel added a commit that referenced this pull request Oct 13, 2013
fix issues with running NWChem test cases, fail early in case broken symlink is present
@boegel boegel merged commit 4349e9a into easybuilders:v1.8.x Oct 13, 2013
@boegel boegel deleted the fix_nwchem branch October 13, 2013 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants