Skip to content

update OpenFOAM easyblock to support OpenFOAM 10 + clean up variant/version checks#2766

Merged
boegel merged 3 commits intoeasybuilders:developfrom
ComputeCanada:openfoam-10
Oct 3, 2022
Merged

update OpenFOAM easyblock to support OpenFOAM 10 + clean up variant/version checks#2766
boegel merged 3 commits intoeasybuilders:developfrom
ComputeCanada:openfoam-10

Conversation

@mboisson
Copy link
Copy Markdown
Contributor

I introduce is_extend, is_dot_org and is_dot_com, and use them to simplify the logic which was becoming rather unwieldy with version comparisons.

The second commit is to update OpenFOAM's list of tools for version 10+

@boegel boegel changed the title Openfoam 10 update OpenFOAM easyblock to support OpenFOAM 10 + clean up variant/version checks Aug 3, 2022
@boegel boegel added this to the 4.x milestone Aug 3, 2022
@kosl
Copy link
Copy Markdown

kosl commented Sep 19, 2022

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-7-foss-2019b-20200508.eb
  • SUCCESS OpenFOAM-8-foss-2020a.eb
  • SUCCESS OpenFOAM-8-foss-2020b.eb
  • SUCCESS OpenFOAM-9-foss-2021a.eb
  • SUCCESS OpenFOAM-v2006-foss-2020a.eb
  • SUCCESS OpenFOAM-v2012-foss-2020a.eb
  • SUCCESS OpenFOAM-v2106-foss-2021a.eb
  • SUCCESS OpenFOAM-v2112-foss-2021b.eb

Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3703.slaking.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.6.8
See https://gist.github.com/9a996abc405d89d721ad9e5c049a7706 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, next release (4.6.2?) Oct 3, 2022
@boegel boegel merged commit 4b49af7 into easybuilders:develop Oct 3, 2022
@mboisson mboisson deleted the openfoam-10 branch October 3, 2022 15:51
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-Extend-4.1-20200408-foss-2019b-Python-2.7.16.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3701.slaking.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.6.8
See https://gist.github.com/1494b4f3c504a836c0621e45dfb03f02 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants