enhance psmpi easyblock to activate CUDA support when it is a dependency + make check for static libs in MPICH easyblock optional#2787
Merged
SebastianAchilles merged 4 commits intoeasybuilders:developfrom Jul 4, 2024
Conversation
and to make the check for static libs in mpich optional, as they aren't always there
ocaisa
approved these changes
Sep 30, 2022
Member
ocaisa
left a comment
There was a problem hiding this comment.
LGTM Any chance we can get a test report?
Member
|
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Member
Author
|
This kind of stalled, but in principle there is no reason to don't merge I guess. Ping @SebastianAchilles @ocaisa @boegel |
…asyblocks into psmpi_cuda_and_check_static_libs
SebastianAchilles
approved these changes
Jul 4, 2024
Member
SebastianAchilles
left a comment
There was a problem hiding this comment.
Thank you for your contribution, and I'm sorry that this PR got stalled.
I’ve reviewed the changes:
- The modifications appear reasonable.
- We received a successful test report.
- The modified EasyBlocks have been used at JSC for some time.
LGTM!
Member
|
Going in, thanks @damianam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and to make the check for static libs in mpich optional, as they aren't always there