make the test output from PythonPackage less verbose by disabling default search for error patterns done by run_cmd#2797
Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom Oct 7, 2022
Conversation
When the EasyBlock wants to handle the test output itself it doesn't make sense to search it for potential errors using the generic RegExp. This applies e.g. to PyTorch and TensorFlow which search for test failures themselves. So set `regexp=False` to avoid making the log much harder to read due to duplicated and, more annoyingly, partial test (fail) output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the EasyBlock wants to handle the test output itself it doesn't make sense to search it for potential errors using the generic RegExp.
This applies e.g. to PyTorch and TensorFlow which search for test failures themselves.
So set
regexp=Falseto avoid making the log much harder to read due to duplicated and, more annoyingly, partial test (fail) output.