Skip to content

handle iterative builds with MakeCp easyblock#2798

Merged
bartoldeman merged 2 commits intoeasybuilders:developfrom
ComputeCanada:makecp_iterative
Oct 7, 2022
Merged

handle iterative builds with MakeCp easyblock#2798
bartoldeman merged 2 commits intoeasybuilders:developfrom
ComputeCanada:makecp_iterative

Conversation

@mboisson
Copy link
Copy Markdown
Contributor

@mboisson mboisson commented Oct 6, 2022

Without this, an iterative build that uses the MakeCp EasyBlock is likely to fail when copying a directory multiple times.

Files don't have this issue, since EasyBuild will simply compare their content and log a message that it's not copying the file twice since it is identical.

Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman added this to the next release (4.6.2?) milestone Oct 7, 2022
@bartoldeman bartoldeman merged commit 73c9ee6 into easybuilders:develop Oct 7, 2022
@boegel boegel changed the title handle iterative builds with MakeCP EasyBlock handle iterative builds with MakeCp easyblock Oct 12, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 12, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS vt-0.57721-GCC-10.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3701.slaking.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.6.8
See https://gist.github.com/2c1fb021f6f32bfc02f9ab71d5fe18bd for a full test report.

@mboisson mboisson deleted the makecp_iterative branch October 12, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants