Fix bugs in the HDF5 easyblocks#286
Merged
boegel merged 2 commits intoeasybuilders:developfrom Nov 9, 2013
Merged
Conversation
Merged
|
Can one of the admins verify this patch? |
|
Automatic reply from Jenkins: Can I test this? |
Member
|
ok to test |
Member
|
@besserox: Ouch, nice catch. This means EB has been building |
Member
|
@besserox: I collapsed this PR and #290 together in #301 so I could do some minor cleanup; I didn't like the code duplication after you unrolled the Great work, thanks for contributing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configure option of HDF5 for Szip is actually --with-szlib and not --with-szip.
This is documented in http://www.hdfgroup.org/ftp/HDF5/current/src/unpacked/release_docs/INSTALL
I verified that this option is valid for HDF5 1.8.7, 1.8.9, 1.8.10 and 1.8.11.