Skip to content

add testinstall custom easyconfig parameter to PythonPackage easyblock#2872

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20230130142534_new_pr_pythonpackage
Feb 1, 2023
Merged

add testinstall custom easyconfig parameter to PythonPackage easyblock#2872
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20230130142534_new_pr_pythonpackage

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jan 30, 2023

(created using eb --new-pr)

Seems to be required for e.g. CuPy (see Slack discussion) and we already implemented the functionality to install the Python package prior to testing but it was only accessible for EasyBlocks. This allows to set it from inside an EC (but can be overwritten by EasyBlocks).

@boegel boegel changed the title Add testinstall EC option to PythonPackage add testinstall custom easyconfig parameter to PythonPackage easyblock Feb 1, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 1, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS tqdm-4.64.0-GCCcore-11.3.0.eb
  • SUCCESS matplotlib-3.5.2-intel-2022a.eb
  • SUCCESS EasyBuild-4.7.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3155.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/023739bb74ae1396dc15c01b8d953f25 for a full test report.

@boegel boegel merged commit 61d2f58 into easybuilders:develop Feb 1, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 1, 2023
@Flamefire Flamefire deleted the 20230130142534_new_pr_pythonpackage branch February 1, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants