Skip to content

fix checking of CUDA/ROCR-Runtime dependencies for Clang to determine default build targets#2873

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:fix_clang_targets_deps
Jan 30, 2023
Merged

fix checking of CUDA/ROCR-Runtime dependencies for Clang to determine default build targets#2873
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:fix_clang_targets_deps

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 30, 2023

fixes #2871

Works as expected, now getting this in the log, as intended:

== 2023-01-30 14:55:17,205 clang.py:194 DEBUG Using ['X86', 'NVPTX'] as default build targets for CPU/GPU architecture x86_64.

@boegel boegel added the bug fix label Jan 30, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Jan 30, 2023
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jan 30, 2023

I was just creating the exact same PR...

ocaisa
ocaisa previously approved these changes Jan 30, 2023
Comment thread easybuild/easyblocks/c/clang.py Outdated
@ocaisa ocaisa dismissed their stale review January 30, 2023 14:30

Requiring a change

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 30, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-13.0.1-GCCcore-11.2.0-CUDA-11.4.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3905.accelgor.os - Linux RHEL 8.6, x86_64, AMD EPYC 7413 24-Core Processor (zen3), 4 x NVIDIA NVIDIA A100-SXM4-80GB, 525.60.13, Python 3.6.8
See https://gist.github.com/72e59e4b9212cd9b54adab64299cee3d for a full test report.

@ocaisa ocaisa merged commit 3d3a446 into easybuilders:develop Jan 30, 2023
@boegel boegel deleted the fix_clang_targets_deps branch January 30, 2023 16:43
@boegel boegel mentioned this pull request Jan 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

building Clang with NVPTX support is broken

2 participants