Skip to content

relax glob pattern to find Mathematica install script#2896

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230225191513_new_pr_mathematica
Feb 28, 2023
Merged

relax glob pattern to find Mathematica install script#2896
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230225191513_new_pr_mathematica

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2023 •
edited
Loading

(created using eb --new-pr)

For Mathematica 13.1.0, the name of the script is just Mathematica_13.1.0_LINUX.sh

@boegel boegel added the update label Feb 25, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 25, 2023
@boegel boegel added the bug fix label Feb 25, 2023
@boegel boegel mentioned this pull request Feb 25, 2023
Merged
Micket
Micket approved these changes Feb 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (though i don't have access to that version yet)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 2 (2 easyconfigs in total)
node3704.slaking.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.6.8
See https://gist.github.com/0ec325e1bc910395b6e8529d56d63ff2 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Feb 27, 2023

@boegel I'm afraid I merged the easyconfig before @Micket pointed out that this easyblock hadn't gone in yet.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 28, 2023

I'm not sure what's causing the Segmentation fault when running mathematica --version during the sanity check, but I guess it could have something to do with not having enough memory available.

It definitely has nothing to do with the changes being made here to the easyblock though, that's clear imho...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 28, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Mathematica-12.1.1.eb
  • SUCCESS Mathematica-13.0.0.eb
  • SUCCESS Mathematica-13.1.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3121.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/5e19e102b1601adf8cbd9ae8ff589413 for a full test report.

@Micket Micket merged commit cc91afc into easybuilders:develop Feb 28, 2023
@boegel boegel deleted the 20230225191513_new_pr_mathematica branch February 28, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix update

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @verdurin @Micket