Skip to content

add output log to MATLAB installs, actually parse for common errors#2924

Merged
smoors merged 6 commits intoeasybuilders:developfrom
Micket:20230503033317_new_pr_matlab
May 5, 2023
Merged

add output log to MATLAB installs, actually parse for common errors#2924
smoors merged 6 commits intoeasybuilders:developfrom
Micket:20230503033317_new_pr_matlab

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented May 3, 2023

(created using eb --new-pr)

fixes #2880

@Micket Micket added the bug fix label May 3, 2023
@Micket Micket changed the title Add output log to matlab installs, parse for common errors Add output log to matlab installs, actually parse for common errors May 3, 2023
@Micket Micket added this to the next release (4.7.2) milestone May 3, 2023
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 3, 2023

Test with intentional error coming first

@Micket

This comment was marked as resolved.

@Micket

This comment was marked as resolved.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 3, 2023

Hm, i tried changing the output file to an absolute path, but doesn't seem like the installer likes that for some reason :/

(and of course, testing takes ages since it needs to unpack this damn huge iso file each time)

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 3, 2023

Test report by @Micket

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/361f8406cd83a6918a655e823e4b97d5 for a full test report.

This failure was intentional, with wrong key, i get the output:

== FAILED: Installation ended unsuccessfully (build directory: /dev/shm/MATLAB/2023a/system-system): build failed (first 300 chars): Found error pattern 'Not a valid key' in output file of installer (took 1 min 57 secs)

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 3, 2023

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS MATLAB-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/8cfda3117599ab2141f5a163ff6c85d5 for a full test report.

Comment thread easybuild/easyblocks/m/matlab.py Outdated
@Micket Micket requested a review from smoors May 3, 2023 20:39
Comment thread easybuild/easyblocks/m/matlab.py
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 5, 2023

Successfull test build in easybuilders/easybuild-easyconfigs#17728

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 5, 2023

Going in, thanks @Micket!

@smoors smoors merged commit 073d0f4 into easybuilders:develop May 5, 2023
@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 5, 2023

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS MATLAB-2022a-r5.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node378.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.6.8
See https://gist.github.com/smoors/67cf2969cebcf540134cff055401b3e7 for a full test report.

@Micket Micket deleted the 20230503033317_new_pr_matlab branch May 5, 2023 10:42
@boegel boegel changed the title Add output log to matlab installs, actually parse for common errors add output log to MATLAB installs, actually parse for common errors May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MATLAB easyblock doesn't handle errors during install

2 participants