add PerlBundle generic easyblock for installing a bundle of Perl modules#2945
Merged
boegel merged 8 commits intoeasybuilders:developfrom Jun 21, 2023
Merged
Conversation
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
PerlBundle generic easyblock for installing a bundle of Perl modules
boegel
requested changes
Jun 21, 2023
boegel
approved these changes
Jun 21, 2023
Micket
commented
Jun 21, 2023
| super(PerlBundle, self).__init__(*args, **kwargs) | ||
|
|
||
| self.cfg['exts_defaultclass'] = 'PerlModule' | ||
| self.cfg['exts_filter'] = ("perl -e 'require %(ext_name)s'", '') |
Contributor
Author
There was a problem hiding this comment.
If the perl easyblock uses this as well we could import the variable. I thought it more important to do the right thing from the start here.
Member
There was a problem hiding this comment.
Of course, makes sense.
For future reference, see #2699
Member
|
tested with easybuilders/easybuild-easyconfigs#17970, ready to go, thanks @Micket! |
Contributor
|
This causes trouble on Python2 due to the umlaut --> #3008 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)