Skip to content

update scipy easyblock for scipy >= 1.11.0#2971

Merged
casparvl merged 2 commits intoeasybuilders:developfrom
SebastianAchilles:20230802095220_new_pr_scipy
Aug 4, 2023
Merged

update scipy easyblock for scipy >= 1.11.0#2971
casparvl merged 2 commits intoeasybuilders:developfrom
SebastianAchilles:20230802095220_new_pr_scipy

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles commented Aug 2, 2023 •
edited
Loading

(created using eb --new-pr)

This PR is adding support for scipy >= 1.11.0. The runtests.py is not longer available, but dev.py --no-build --install-prefix %(installdir)s test needs to be used.

Before the test_step was already installing scipy into the final install directory. I tried to update the easyblock that in the test step scipy is installed to the tmpdir.

@SebastianAchilles SebastianAchilles mentioned this pull request Aug 2, 2023
Merged
1 task
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Aug 2, 2023
@SebastianAchilles
Copy link
Copy Markdown
Member Author

SebastianAchilles commented Aug 2, 2023

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2022.05-foss-2022a.eb
  • SUCCESS SciPy-bundle-2022.05-intel-2022a.eb
  • SUCCESS SciPy-bundle-2023.02-gfbf-2022b.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
zen2-ubuntu-2304 - Linux Ubuntu 23.04 (Lunar Lobster), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.11.2
See https://gist.github.com/SebastianAchilles/cae44e7602387ac8c92485b09d0550c2 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.8.1?) Aug 2, 2023
@SebastianAchilles
Copy link
Copy Markdown
Member Author

SebastianAchilles commented Aug 2, 2023

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2021.05-foss-2021a.eb
  • SUCCESS SciPy-bundle-2022.05-foss-2022a.eb
  • SUCCESS SciPy-bundle-2023.02-gfbf-2022b.eb
  • SUCCESS SciPy-bundle-2021.10-foss-2021b.eb
  • SUCCESS SciPy-bundle-2022.05-intel-2022a.eb
  • SUCCESS SciPy-bundle-2023.02-gfbf-2022b.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
bwd-rockylinux-92 - Linux Rocky Linux 9.2 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 535.54.03, Python 3.9.16
See https://gist.github.com/SebastianAchilles/f17dcb252b27f5940b2f56d68135c5f5 for a full test report.

casparvl
casparvl approved these changes Aug 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl merged commit d8a8fa3 into easybuilders:develop Aug 4, 2023
boegel
boegel reviewed Aug 4, 2023
View reviewed changes
Comment thread easybuild/easyblocks/s/scipy.py
change_dir(tmp_builddir)

# reconfigure (to update prefix), and install to tmpdir
MesonNinja.configure_step(self, cmd_prefix=tmp_installdir)
Copy link
Copy Markdown
Member

@boegel boegel Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look into why the cmd_prefix didn't work as intended, but that can be done in a follow-up PR...

cmd_prefix isn't used at all in MesonNinja.configure_step currently, so we need to check what's going on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianAchilles @boegel @casparvl