conditionally add `-Wno-unused-command-line-argument` to `$CFLAGS` to fix error when installing `imkl-FFTW` with RPATH by casparvl · Pull Request #2975 · easybuilders/easybuild-easyblocks

casparvl · 2023-08-04T12:56:12Z

Fix for easybuilders/easybuild-easyconfigs#18439 (comment) which pops up as:

icx: error: -Wl,-rpath=$ORIGIN/../lib64: 'linker' input unused [-Werror,-Wunused-command-line-argument]
icx: error: -Wl,--disable-new-dtags: 'linker' input unused [-Werror,-Wunused-command-line-argument]

casparvl · 2023-08-04T14:44:24Z

Test report by @casparvl

Overview of tested easyconfigs (in order)

SUCCESS imkl-FFTW-2022.1.0-iimpi-2022a.eb
SUCCESS imkl-FFTW-2021.4.0-iimpi-2021b.eb
SUCCESS imkl-2023.1.0.eb
SUCCESS imkl-2023.0.0.eb
SUCCESS imkl-2022.2.1.eb
SUCCESS imkl-2022.2.0.eb
SUCCESS imkl-FFTW-2022.2.1-iimpi-2022b.eb
SUCCESS iimpi-2022.11.eb
SUCCESS imkl-FFTW-2022.2.1-iimpi-2022.11.eb
SUCCESS intel-compilers-2023.1.0.eb
SUCCESS intel-compilers-2023.0.0.eb
FAIL (build issue) intel-compilers-2022.2.0.eb (partial log available at https://gist.github.com/casparvl/90918f7808cb4c8545f20cfab06dea60)
FAIL (build issue) impi-2021.9.0-intel-compilers-2023.1.0.eb (partial log available at https://gist.github.com/casparvl/5070bed9add1aa03e5e6ea34ad2e327e)
FAIL (build issue) impi-2021.8.0-intel-compilers-2023.0.0.eb (partial log available at https://gist.github.com/casparvl/7c4ba28f63ff2a9a4346b9bf729c5ed4)
FAIL (build issue) impi-2021.7.0-intel-compilers-2022.2.0.eb (partial log available at https://gist.github.com/casparvl/8c6571ea25404e40739dd066b21724eb)
FAIL (build issue) iimpi-2023a.eb (partial log available at https://gist.github.com/casparvl/c0b1d8e29f14f24a574213214879c357)
FAIL (build issue) iimpi-2023.03.eb (partial log available at https://gist.github.com/casparvl/6b55394aca0a4fd80c2899db63833795)
FAIL (build issue) iimpi-2022.12.eb (partial log available at https://gist.github.com/casparvl/6c1e2098e3abe2eb5d818bc676c97d62)
FAIL (build issue) iimpi-2022.09.eb (partial log available at https://gist.github.com/casparvl/1474dfafa85a06cdc2eb3bb7110f2439)
FAIL (build issue) imkl-FFTW-2023.1.0-iimpi-2023a.eb (partial log available at https://gist.github.com/casparvl/57e962693408879d098dbacc106570bc)
FAIL (build issue) imkl-FFTW-2023.1.0-iimpi-2023.03.eb (partial log available at https://gist.github.com/casparvl/588ffe0e0a1d35d6b56086c7fc2aa98e)
FAIL (build issue) imkl-FFTW-2023.0.0-iimpi-2022.12.eb (partial log available at https://gist.github.com/casparvl/88473742073294387a98744e7d7114ed)
FAIL (build issue) imkl-FFTW-2022.2.0-iimpi-2022.09.eb (partial log available at https://gist.github.com/casparvl/6ab5f8baecf1497fb948e971e49a0a5e)

Build succeeded for 11 out of 23 (8 easyconfigs in total)
tcn174.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/db7d09a93a3330968889beab080dac2d for a full test report.

casparvl · 2023-08-04T14:47:54Z

Ugh, I'm getting failures because I'm exceeding my inode quotum... Will cleanup first, then retry...

boegel · 2023-08-04T15:08:42Z

+                # Avoid unused command line arguments (-Wl,rpath...) causeing errors when using RPATH
+                # See https://github.com/easybuilders/easybuild-easyconfigs/pull/18439#issuecomment-1662671054
+                if build_option('rpath'):
+                    cflags = flags + ' -Wno-unused-command-line-argument'


This option is probably only supported for Intel oneAPI (Clang-based) compilers, so this needs an extra condition?

Had some discussion on Slack. This is correct: it's supported by Clang-based compilers. Hence we should limit it to those. The problem that I'm trying to address in this PR should also only occur for Clang based compilers (that's why we haven't run into it with prior versions if imkl-fftw: we didn't use the oneAPI compilers yet by default there).

…based compilers

bedroge · 2023-08-04T17:14:22Z

Looks like the same issue as this one: #2910 (which I tried to fix with #2912).

casparvl · 2023-08-04T18:03:20Z

Test report by @casparvl

Overview of tested easyconfigs (in order)

SUCCESS imkl-FFTW-2022.2.1-iimpi-2022b.eb
SUCCESS imkl-FFTW-2022.2.1-iimpi-2022.11.eb
SUCCESS imkl-FFTW-2022.1.0-iimpi-2022a.eb
SUCCESS imkl-FFTW-2021.4.0-iimpi-2021b.eb
SUCCESS impi-2021.9.0-intel-compilers-2023.1.0.eb
SUCCESS impi-2021.8.0-intel-compilers-2023.0.0.eb
SUCCESS intel-compilers-2022.2.0.eb
SUCCESS iimpi-2023a.eb
SUCCESS iimpi-2023.03.eb
SUCCESS iimpi-2022.12.eb
SUCCESS imkl-FFTW-2023.1.0-iimpi-2023a.eb
SUCCESS imkl-FFTW-2023.1.0-iimpi-2023.03.eb
SUCCESS imkl-FFTW-2023.0.0-iimpi-2022.12.eb
SUCCESS impi-2021.7.0-intel-compilers-2022.2.0.eb
SUCCESS iimpi-2022.09.eb
SUCCESS imkl-FFTW-2022.2.0-iimpi-2022.09.eb

Build succeeded for 16 out of 16 (8 easyconfigs in total)
tcn174.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/1520e3ad48145b0e1a58388bafff2a0f for a full test report.

casparvl · 2023-08-07T10:08:02Z

Looks like the same issue as this one: #2910 (which I tried to fix with #2912).

Arrggg, why do I have such a terrible memory, I even commented in that issue...

So, @bedroge @boegel any preference? @bedroge 's approach is a bit more targetted. That has the advantage that we know this change has to be made for intel-compilers when using the oneapi compilers. My PR would also include clang compiling FFTW. That would probably work, but is untested. One could argue that it is easy enough to add clang to the if-statement in @bedroge 's PR once it is relevant.

The downside is there was some issue with --read-only-installdir it seems, in @bedroge 's PR? Though @boegel wasn't sure.

boegel · 2023-08-08T10:44:25Z

The approach takes in #2912 highlight a problem with imkl-FFTW which we should fix first, but the changes here are OK short-term (it doesn't make a bad situation worse, and it's a reasonable fix for the problem), so let's merge this PR, and revisit #2912 once imkl-FFTW has been changed to not build the FFTW interfaces directly in the imkl installation directory.

boegel · 2023-08-08T14:32:34Z

Test report by @boegel

Overview of tested easyconfigs (in order)

SUCCESS imkl-FFTW-2021.4.0-gompi-2021b.eb
SUCCESS imkl-FFTW-2021.4.0-iimpi-2021b.eb
SUCCESS imkl-FFTW-2022.0.1-iimpi-2022.00.eb
SUCCESS imkl-FFTW-2022.1.0-iimpi-2022.05.eb
SUCCESS imkl-FFTW-2022.1.0-iimpi-2022a.eb
SUCCESS imkl-FFTW-2022.2.0-iimpi-2022.09.eb
SUCCESS imkl-FFTW-2022.2.1-iimpi-2022.11.eb
SUCCESS imkl-FFTW-2022.2.1-iimpi-2022b.eb
SUCCESS imkl-FFTW-2023.0.0-iimpi-2022.12.eb
SUCCESS imkl-FFTW-2023.1.0-iimpi-2023.03.eb
SUCCESS imkl-FFTW-2023.1.0-iimpi-2023a.eb

Build succeeded for 11 out of 11 (11 easyconfigs in total)
node3115.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/7f016d8756ace156914b0be74818b1ad for a full test report.

Fix unused cmd line argument error for use of RPATH + imkl-fftw

2c94936

casparvl added the bug fix label Aug 4, 2023

casparvl added this to the 4.x milestone Aug 4, 2023

casparvl mentioned this pull request Aug 4, 2023

{toolchain} intel/2023.07 easybuilders/easybuild-easyconfigs#18439

Merged

boegel reviewed Aug 4, 2023

View reviewed changes

Add condition on the compiler that is set. Don't do it for non-clang …

3408587

…based compilers

casparvl mentioned this pull request Aug 7, 2023

avoid warnings being treated as errors when installing imkl-FFTW with Intel OneAPI compilers and RPATH linking #2912

Open

boegel modified the milestones: 4.x, next release (4.8.1?) Aug 8, 2023

boegel changed the title ~~Fix unused cmd line argument error for use of RPATH + imkl-fftw~~ conditionally add -Wno-unused-command-line-argument to $CFLAGS to fix error when installing imkl-FFTW with RPATH Aug 8, 2023

boegel requested changes Aug 8, 2023

View reviewed changes

Comment thread easybuild/easyblocks/i/imkl.py Outdated

fix typo in comment

75995ee

boegel approved these changes Aug 8, 2023

View reviewed changes

boegel merged commit 8893856 into easybuilders:develop Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

conditionally add `-Wno-unused-command-line-argument` to `$CFLAGS` to fix error when installing `imkl-FFTW` with RPATH#2975

conditionally add `-Wno-unused-command-line-argument` to `$CFLAGS` to fix error when installing `imkl-FFTW` with RPATH#2975
boegel merged 3 commits intoeasybuilders:developfrom
casparvl:fftw_intel_rpath

casparvl commented Aug 4, 2023 •

edited by boegel

Loading

Uh oh!

casparvl commented Aug 4, 2023

Uh oh!

casparvl commented Aug 4, 2023

Uh oh!

boegel Aug 4, 2023

Uh oh!

casparvl Aug 4, 2023

Uh oh!

bedroge commented Aug 4, 2023

Uh oh!

casparvl commented Aug 4, 2023

Uh oh!

casparvl commented Aug 7, 2023

Uh oh!

Uh oh!

boegel commented Aug 8, 2023

Uh oh!

boegel commented Aug 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

casparvl commented Aug 4, 2023 • edited by boegel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

casparvl commented Aug 4, 2023

Overview of tested easyconfigs (in order)

Uh oh!

casparvl commented Aug 4, 2023

Uh oh!

boegel Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

casparvl Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

bedroge commented Aug 4, 2023

Uh oh!

casparvl commented Aug 4, 2023

Overview of tested easyconfigs (in order)

Uh oh!

casparvl commented Aug 7, 2023

Uh oh!

Uh oh!

boegel commented Aug 8, 2023

Uh oh!

boegel commented Aug 8, 2023

Overview of tested easyconfigs (in order)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

casparvl commented Aug 4, 2023 •

edited by boegel

Loading