Skip to content

take into account that posix_local Python naming scheme only matters when using pip install in PythonPackage easyblock#2988

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20230825152057_new_pr_pythonpackage
Aug 25, 2023
Merged

take into account that posix_local Python naming scheme only matters when using pip install in PythonPackage easyblock#2988
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20230825152057_new_pr_pythonpackage

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 25, 2023 •
edited
Loading

(created using eb --new-pr)

fixes #2976

@boegel
take into account that 'posix_local' Python naming scheme only matter…
535b363 
…s when using 'pip install' in PythonPackage easyblock (fixes easybuilders#2976)
@boegel boegel mentioned this pull request Aug 25, 2023
Closed
@boegel boegel requested a review from akesandgren August 25, 2023 13:23
@boegel boegel added the bug fix label Aug 25, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 25, 2023
@boegel boegel changed the title take into account that 'posix_local' Python naming scheme only matters when using 'pip install' in PythonPackage easyblock (fixes #2976) take into account that 'posix_local' Python naming scheme only matters when using 'pip install' in PythonPackage easyblock Aug 25, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 25, 2023 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4003.donphan.os - Linux Ubuntu 22.04.3 LTS (Jammy Jellyfish), x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 3.10.12
See https://gist.github.com/boegel/f6c2eec5add32b96175ff5f673ac9952 for a full test report.

edit: this was with a vanilla Ubuntu 22.04 setup that includes Python 3.10 + matching pip, no patching of /lib/python3.10/sysconfig.py, so custom posix_local Python naming scheme is actually used

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 25, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3118.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/9591adc45611423ccceeb32b20ef4e0c for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 25, 2023 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4003.donphan.os - Linux Ubuntu 22.04.3 LTS (Jammy Jellyfish), x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 3.10.12
See https://gist.github.com/boegel/967f5e1a45fd8b9b4649b729b09ea703 for a full test report.

edit: this was with a vanilla Ubuntu 22.04 setup that includes Python 3.10 but without pip, no patching of /lib/python3.10/sysconfig.py (cfr. #2976), so custom posix_local Python naming scheme is not actually used (because setup.py install --prefix is used)

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 25, 2023

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.6.0.eb
  • SUCCESS EasyBuild-4.6.1.eb
  • SUCCESS EasyBuild-4.6.2.eb
  • SUCCESS EasyBuild-4.7.0.eb
  • SUCCESS EasyBuild-4.7.1.eb
  • SUCCESS EasyBuild-4.7.2.eb
  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
zen2-ubuntu-2304 - Linux Ubuntu 23.04 (Lunar Lobster), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.11.4
See https://gist.github.com/SebastianAchilles/0d64c07d0fd6a658720163a13704818b for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 25, 2023

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.6.0.eb
  • SUCCESS EasyBuild-4.6.1.eb
  • SUCCESS EasyBuild-4.6.2.eb
  • SUCCESS EasyBuild-4.7.0.eb
  • SUCCESS EasyBuild-4.7.1.eb
  • SUCCESS EasyBuild-4.7.2.eb
  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
zen2-ubuntu-2204 - Linux Ubuntu 22.04.3 LTS (Jammy Jellyfish), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.12
See https://gist.github.com/SebastianAchilles/a49ad88d841bc2e5a2d8dc106bd73ab9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 25, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
vpnf117.ugent.be - Darwin UNKNOWN UNKNOWN, AArch64, Apple M1 (m1), Python 3.9.6
See https://gist.github.com/boegel/6636ec4f34e95dce333a9bc89736cfb6 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 25, 2023 •
edited
Loading

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.8.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
skalman.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz, Python 3.10.12
See https://gist.github.com/akesandgren/e651a25a558d003bf086c182aa4bfb77 for a full test report.

This one is also Ubuntu 22.04 Python 3.10 without patching and without pip, thus using "setup.py install --prefix", i.e. the setup that triggered the problem solved by this PR

akesandgren
akesandgren approved these changes Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 25, 2023

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 5e79245 into easybuilders:develop Aug 25, 2023
@boegel boegel deleted the 20230825152057_new_pr_pythonpackage branch August 25, 2023 15:26
@boegel boegel changed the title take into account that 'posix_local' Python naming scheme only matters when using 'pip install' in PythonPackage easyblock take into account that posix_local Python naming scheme only matters when using pip install in PythonPackage easyblock Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

Python packages are being installed to local/lib/python*/dist-packages due to tweaks to sysconfig.py in OS (Ubuntu 22.04)

3 participants

@boegel @SebastianAchilles @akesandgren