Skip to content

fix typo in TensorFlow easyblock when finding libdir of OpenSSL#2989

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
akesandgren:20230828155635_new_pr_tensorflow
Aug 29, 2023
Merged

fix typo in TensorFlow easyblock when finding libdir of OpenSSL#2989
branfosj merged 1 commit intoeasybuilders:developfrom
akesandgren:20230828155635_new_pr_tensorflow

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@akesandgren akesandgren added this to the 4.x milestone Aug 28, 2023
@akesandgren akesandgren changed the title fix type in tensorflow.py when finding libdir of OpenSSL fix typo in tensorflow.py when finding libdir of OpenSSL Aug 28, 2023
@akesandgren
Copy link
Copy Markdown
Contributor Author

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.11.0-foss-2022a-CUDA-11.7.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 525.125.06, Python 3.10.6
See https://gist.github.com/akesandgren/07c03dbae5e6898cab5258585cdc2b6c for a full test report.

@branfosj branfosj merged commit 643a089 into easybuilders:develop Aug 29, 2023
@akesandgren akesandgren deleted the 20230828155635_new_pr_tensorflow branch August 29, 2023 10:24
@boegel boegel changed the title fix typo in tensorflow.py when finding libdir of OpenSSL fix typo in TensorFlow easyblock when finding libdir of OpenSSL Aug 30, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 30, 2023

Small note here just to clarify: there's really no negative impact for this bug, because get_software_libdir basically returns 'lib' for both 'OpenSSL' and whatever dependency name was in dep_name. The fix is correct and make sense, but due to sheer luck there actually was no problem in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants