Skip to content

update numpy easyblock to be able to use FlexiBLAS with MKL as dependency#2999

Merged
boegel merged 4 commits intoeasybuilders:developfrom
SebastianAchilles:20230911112217_new_pr_numpy
Sep 14, 2023
Merged

update numpy easyblock to be able to use FlexiBLAS with MKL as dependency#2999
boegel merged 4 commits intoeasybuilders:developfrom
SebastianAchilles:20230911112217_new_pr_numpy

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles commented Sep 11, 2023

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles force-pushed the 20230911112217_new_pr_numpy branch from e3fb71e to 3eef297 Compare September 11, 2023 09:25
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 11, 2023
@SebastianAchilles SebastianAchilles force-pushed the 20230911112217_new_pr_numpy branch from 3eef297 to ee5ef6c Compare September 11, 2023 09:26
@surak
Copy link
Copy Markdown
Contributor

surak commented Sep 12, 2023

It still asks for mkl on line 150

ocaisa
ocaisa reviewed Sep 12, 2023
View reviewed changes
Comment thread easybuild/easyblocks/n/numpy.py Outdated
@boegel boegel changed the title update numpy easyblock to be able to use FlexiBLAS with MKL as dependcy update numpy easyblock to be able to use FlexiBLAS with MKL as dependency Sep 13, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 13, 2023

@surak Should be fixed with a97f70e, please try again with --include-easyblocks-from-pr 2999 ?

@boegel boegel modified the milestones: 4.x, next release (4.8.2?) Sep 13, 2023
@surak
Copy link
Copy Markdown
Contributor

surak commented Sep 13, 2023

@boegel Works for me now!

akesandgren
akesandgren reviewed Sep 13, 2023
View reviewed changes
Comment thread easybuild/easyblocks/n/numpy.py Outdated
@SebastianAchilles
Copy link
Copy Markdown
Member Author

SebastianAchilles commented Sep 13, 2023

Thanks for spotting the problem @surak and thanks to @ocaisa and @boegel for improving the PR 👍

boegel
boegel approved these changes Sep 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2023.07-gfbf-2023a.eb
  • SUCCESS SciPy-bundle-2021.10-intel-2021b.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3171.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/3e81ac1000fdad63514a3800bd52a9f7 for a full test report.

@boegel boegel merged commit dc58e27 into easybuilders:develop Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren left review comments

@ocaisa ocaisa ocaisa left review comments

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

5 participants

@SebastianAchilles @surak @boegel @akesandgren @ocaisa