Skip to content

don't blindly overwrite -Dccflags + honour preconfigopts in Perl easyblock#3010

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:20230930162526_new_pr_perl
Oct 23, 2023
Merged

don't blindly overwrite -Dccflags + honour preconfigopts in Perl easyblock#3010
akesandgren merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:20230930162526_new_pr_perl

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles commented Sep 30, 2023

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles mentioned this pull request Sep 30, 2023
Merged
@boegel boegel changed the title add check for -Dccflags and add preconfigopts in perl easyblock don't blindly overwrite -Dccflags + honour preconfigopts in Perl easyblock Oct 10, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Oct 10, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 10, 2023

@boegelbot please test @ generoso
EB_ARGS="Perl-5.38.0-GCCcore-13.2.0.eb Perl-5.32.1-GCCcore-10.3.0.eb --installpath /tmp/$USER/pr3010"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Oct 10, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3010 EB_ARGS="Perl-5.38.0-GCCcore-13.2.0.eb Perl-5.32.1-GCCcore-10.3.0.eb --installpath /tmp/$USER/pr3010" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3010 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11914

Test results coming soon (I hope)...

Details

- notification for comment with ID 1756117306 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Oct 10, 2023

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-5.38.0-GCCcore-13.2.0.eb
  • SUCCESS Perl-5.32.1-GCCcore-10.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6bf694c1191007c5ef36041d89a7cc3e for a full test report.

akesandgren
akesandgren approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Oct 23, 2023

Going in, thanks @SebastianAchilles!

@akesandgren akesandgren merged commit 0d2bb58 into easybuilders:develop Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

4 participants

@SebastianAchilles @boegel @boegelbot @akesandgren