Skip to content

don't auto-enable use of -DSCOTCH_PTHREAD when using MPI library other than Intel MPI in SCOTCH easyblock#3019

Merged
casparvl merged 1 commit intoeasybuilders:5.0.xfrom
Micket:scotch_threaded
Oct 17, 2023
Merged

don't auto-enable use of -DSCOTCH_PTHREAD when using MPI library other than Intel MPI in SCOTCH easyblock#3019
casparvl merged 1 commit intoeasybuilders:5.0.xfrom
Micket:scotch_threaded

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 11, 2023 •
edited
Loading

Should have been done for EB 3.0 according to the comment in the script. No need to convert any old easyconfigs back into the old behavior to try and preserve anything, because old behavior is bad; i'm pretty sure we want this.

cf. in easybuilders/easybuild-easyconfigs#17459 (comment)

Fixes #2972

@Micket Micket added change EasyBuild-5.0 EasyBuild 5.0 labels Oct 11, 2023
@Micket Micket added this to the 5.0 milestone Oct 11, 2023
@boegel boegel changed the title Drop old threadedmpi behaviour Drop old threadedmpi behaviour for SCOTCH Oct 11, 2023
@boegel boegel changed the title Drop old threadedmpi behaviour for SCOTCH don't auto-enable use of -DSCOTCH_PTHREAD when using MPI library other than Intel MPI in SCOTCH easyblock Oct 11, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 11, 2023

see also discussion in #914

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 16, 2023

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS SCOTCH-7.0.3-gompi-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/62bc193be0f01073c29e9a32aafdbf75 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 16, 2023

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS SCOTCH-7.0.3-gompi-2022b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/5572fe430a4c18bcbb843d72bec2f962 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Oct 16, 2023

Test report by @casparvl

Overview of tested easyconfigs (in order)

  • SUCCESS SCOTCH-7.0.1-gompi-2022a.eb
  • SUCCESS SCOTCH-7.0.1-iimpi-2022a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/d197eab2502ad7f5d56387d8295a92cd for a full test report.

@Micket Micket mentioned this pull request Oct 17, 2023
Merged
casparvl
casparvl approved these changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I'm just checking with other maintainers how the PRs that target 5.0 are handled, before I press the merge button. Want to make extra sure I don't create an unwanted situation where 5.0 stuff ends up in a 4.X release ;-)

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Oct 17, 2023

Ok, all good, I see this targets the 5.0.X branch. Good to go!

@casparvl casparvl merged commit bb8277d into easybuilders:5.0.x Oct 17, 2023
@Micket Micket deleted the scotch_threaded branch October 17, 2023 14:22
@boegel boegel mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

change EasyBuild-5.0 EasyBuild 5.0

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegel @casparvl