Skip to content

add custom easyblock for flook that includes install step#3034

Merged
ocaisa merged 5 commits intoeasybuilders:developfrom
ahkole:flook
Nov 15, 2023
Merged

add custom easyblock for flook that includes install step#3034
ocaisa merged 5 commits intoeasybuilders:developfrom
ahkole:flook

Conversation

@ahkole
Copy link
Copy Markdown
Contributor

@ahkole ahkole commented Nov 15, 2023

The software flook (https://github.com/ElectronicStructureLibrary/flook) has an unconventional build system. It doesn't have a configure script and requires a manual config file, but it does have an install step. The currently available flook easyconfig uses the MakeCp generic easyblock which works fine in most cases but it doesn't automatically install the pkgconf that might be needed by other software to automatically detect that flook has been installed. This PR adds a new easyblock for flook that also performs the install step so that the pkgconf file is generated and installed.

@ahkole ahkole mentioned this pull request Nov 15, 2023
Merged
1 task
@ahkole
Copy link
Copy Markdown
Contributor Author

ahkole commented Nov 15, 2023

The easyblock is used in easybuilders/easybuild-easyconfigs#19238

ocaisa
ocaisa approved these changes Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Nov 15, 2023

EasyBlock tests are in easybuilders/easybuild-easyconfigs#19238 and works great, thanks a lot @ahkole!

@ocaisa ocaisa merged commit d9ecd18 into easybuilders:develop Nov 15, 2023
@boegel boegel added the new label Nov 22, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 22, 2023
@boegel boegel changed the title Added easyblock for flook that includes install step add custom easyblock for flook that includes install step Nov 22, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 22, 2023

@ahkole Would it make sense to also update the existing flook easyconfigs to use this easyblock (at least the ones using a supported toolchain, see also https://docs.easybuild.io/policies/toolchains)?

@ahkole
Copy link
Copy Markdown
Contributor Author

ahkole commented Nov 22, 2023

@ahkole Would it make sense to also update the existing flook easyconfigs to use this easyblock (at least the ones using a supported toolchain, see also https://docs.easybuild.io/policies/toolchains)?

@boegel I think this would make sense yes. Looking at the other flook easyconfigs they only differ in the toolchain used and the new version properly installs the pkgconfig file which makes it detectable by build systems like cmake. The other easyconfigs could also benefit from this. Should I open a PR for this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 28, 2023

@ahkole Would it make sense to also update the existing flook easyconfigs to use this easyblock (at least the ones using a supported toolchain, see also https://docs.easybuild.io/policies/toolchains)?

@boegel I think this would make sense yes. Looking at the other flook easyconfigs they only differ in the toolchain used and the new version properly installs the pkgconfig file which makes it detectable by build systems like cmake. The other easyconfigs could also benefit from this. Should I open a PR for this?

@ahkole Please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ahkole @ocaisa @boegel