add easyblock for OpenBabel#305
Merged
boegel merged 11 commits intoeasybuilders:developfrom Nov 12, 2013
Merged
Conversation
…thon lib/include paths to CMake, add custom sanity check paths in easyblock
Member
Author
|
@wpoely86: Please review this compared to your original OpenBabel easyblock? |
Member
There was a problem hiding this comment.
We aren't very consistent in adding a space before or after. What's the general rule?
Member
Author
There was a problem hiding this comment.
hmm, good point, I'll make that consistent
Member
Author
|
Jenkins: please test this |
Member
|
Builds works for me. Ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this builds on PR #504 by @wpoely86, includes several fixes w.r.t. Python, adds sanity check paths in easyblock