take into account that binutils might be a filtered dependency for TensorFlow#3058
Conversation
E.g. when using `--filter-deps binutils` in combination with `--rpath` the could could fail to determine the files from binutils to collect as the "software root" won't be set. Fall back to collecting all rpath wrappers and a list of known binutils
|
I've kicked off a build |
|
Test report by @jfgrimm Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) edit: ignore this, I need to use easyconfig from easybuilders/easybuild-easyconfigs#19268 when building TensorFlow in EESSI with EasyBuild 4.8.2, trying again... |
|
Successful test in EESSI build environment, see test report at easybuilders/easybuild-easyconfigs#19268 (comment) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Tested by @jfgrimm with RPATH enabled, tested in EESSI build environment, tested without RPATH or EESSI, so good to go, thanks @Flamefire! |
E.g. when using
--filter-deps binutilsin combination with--rpaththe could could fail to determine the files from binutils to collect as the "software root" won't be set.Fall back to collecting all rpath wrappers and a list of known binutils
Followup to #3054 similar to #2218
Logic is:
While at it I double-checked the other uses of
whichand used the new list of binutils inpatch_crosstool_filespreserving the existing behavior of raising an error if one of those we currently have isn't found.Would be great if @jfgrimm could verify this new version still works but I assume it doesn't change behavior for this case as it should basically do exactly the same.
cc @boegel