improve generate_crate_list + parsing of crates in Cargo easyblock#3084
Merged
branfosj merged 2 commits intoeasybuilders:developfrom Jan 20, 2024
Merged
improve generate_crate_list + parsing of crates in Cargo easyblock#3084branfosj merged 2 commits intoeasybuilders:developfrom
generate_crate_list + parsing of crates in Cargo easyblock#3084branfosj merged 2 commits intoeasybuilders:developfrom
Conversation
- Handle missing package name by using folder name - Fix handling of source with revision -> Output 4-tuple
Handling of 4-tuples `(crate, version, repo, rev)` removed parts of the reponame as it expected a `.git` extension which is not always present. Also the `source_urls` parameter is redundant as it won't be used.
generate_crate_list + parsing of crates in Cargo easyblock
branfosj
approved these changes
Jan 20, 2024
Member
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 14 out of 14 (12 easyconfigs in total) |
Member
|
Going in, thanks @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
generate_crate_list:cratesfor polars #3078This now also handles lines found in polar such as
source = "git+https://github.com/ritchie46/jsonpath?branch=improve_compiled#24eaf0b4416edff38a4d1b6b17bc4b9f3f047b4b"Also fix the parsing of those 4-tuples
(crate, version, repo, rev)which removed parts of thereponame as it expected a
.gitextension which is not always present.Also the
source_urlsparameter is redundant as it won't be used.