Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for wxPython (wxpython.py)#3093

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240127133616_new_pr_wxpython
Jan 29, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for wxPython (wxpython.py)#3093
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240127133616_new_pr_wxpython

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 27, 2024 •
edited
Loading

(created using eb --new-pr)

  • No use of EB_wxPython in easyconfigs or blocks

@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in wxpython.py replace run_cmd with run_shell_cmd in wxpython.py Jan 27, 2024
@branfosj branfosj added this to the 5.0 milestone Jan 27, 2024
@branfosj branfosj mentioned this pull request Jan 27, 2024
Closed
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 27, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS wxPython-4.2.0-foss-2021b.eb
  • SUCCESS dbus-glib-0.112-GCCcore-10.3.0.eb
  • SUCCESS dbus-glib-0.112-GCCcore-11.3.0.eb
  • SUCCESS GConf-3.2.6-GCCcore-10.3.0.eb
  • SUCCESS GConf-3.2.6-GCCcore-11.3.0.eb
  • SUCCESS GStreamer-1.18.4-GCC-10.3.0.eb
  • SUCCESS libpsl-0.21.1-GCCcore-11.3.0.eb
  • SUCCESS GST-plugins-base-1.18.4-GCC-10.3.0.eb
  • SUCCESS attrdict3-2.0.2-GCCcore-11.3.0.eb
  • SUCCESS unifdef-2.12-GCCcore-11.3.0.eb
  • SUCCESS CUnit-2.1-3-GCCcore-11.3.0.eb
  • SUCCESS libunistring-0.9.10-GCCcore-10.3.0.eb
  • SUCCESS hiredis-1.0.2-GCCcore-11.3.0.eb
  • SUCCESS libpsl-0.21.1-GCCcore-10.3.0.eb
  • SUCCESS ccache-4.6.3-GCCcore-11.3.0.eb
  • SUCCESS LibSoup-2.74.0-GCCcore-10.3.0.eb
  • SUCCESS libtasn1-4.17.0-GCCcore-10.3.0.eb
  • SUCCESS nghttp3-0.6.0-GCCcore-11.3.0.eb
  • SUCCESS libgpg-error-1.42-GCCcore-10.3.0.eb
  • SUCCESS libgcrypt-1.9.2-GCCcore-10.3.0.eb
  • SUCCESS Ruby-3.0.5-GCCcore-11.3.0.eb
  • SUCCESS Ruby-3.0.1-GCCcore-10.3.0.eb
  • SUCCESS Jansson-2.14-GCC-11.3.0.eb
  • SUCCESS pugixml-1.12.1-GCCcore-11.3.0.eb
  • SUCCESS WebKitGTK+-2.27.4-GCC-10.3.0.eb
  • SUCCESS wxPython-4.1.1-foss-2021a.eb
  • SUCCESS Waylandpp-1.0.0-GCCcore-11.3.0.eb
  • SUCCESS libev-4.33-GCC-11.3.0.eb
  • SUCCESS libwpe-1.14.1-GCCcore-11.3.0.eb
  • SUCCESS wpebackend-fdo-1.14.1-GCCcore-11.3.0.eb
  • SUCCESS ngtcp2-0.7.0-GCC-11.3.0.eb
  • SUCCESS libavif-0.11.1-GCCcore-11.3.0.eb
  • SUCCESS c-ares-1.18.1-GCCcore-11.3.0.eb
  • SUCCESS hunspell-1.7.1-GCCcore-11.3.0.eb
  • SUCCESS nghttp2-1.48.0-GCC-11.3.0.eb
  • SUCCESS enchant-2-2.3.3-GCCcore-11.3.0.eb
  • SUCCESS LibSoup-3.0.8-GCC-11.3.0.eb
  • SUCCESS WebKitGTK+-2.40.4-GCC-11.3.0.eb
  • SUCCESS wxPython-4.2.1-foss-2022a.eb

Build succeeded for 39 out of 39 (3 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/73df9c9596bd530a22dd546b54079500 for a full test report.

@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in wxpython.py replace run_cmd with run_shell_cmd in custom easyblock for wxPython (wxpython.py) Jan 29, 2024
boegel
boegel approved these changes Jan 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 29, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH="5.0.x"
EB_ARGS="wxPython-4.2.1-foss-2022a.eb --installpath /tmp/$USER/pr3093"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 29, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3093 EB_ARGS="wxPython-4.2.1-foss-2022a.eb --installpath /tmp/$USER/pr3093" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3093 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3508

Test results coming soon (I hope)...

Details

- notification for comment with ID 1915102528 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 29, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS wxPython-4.2.1-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/23ebf57f76c19a3e74290f9b2a5ff89e for a full test report.

@boegel boegel merged commit 5a9be9b into easybuilders:5.0.x Jan 29, 2024
@branfosj branfosj deleted the 20240127133616_new_pr_wxpython branch January 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot