Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for bzip2 (bzip2.py)#3101

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240128172051_new_pr_bzip2
Jan 29, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for bzip2 (bzip2.py)#3101
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240128172051_new_pr_bzip2

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 28, 2024 •
edited
Loading

(created using eb --new-pr)

  • No use of EB_bzip2 in easyconfigs or blocks

@branfosj branfosj added this to the 5.0 milestone Jan 28, 2024
@branfosj branfosj mentioned this pull request Jan 28, 2024
Closed
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 28, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS bzip2-1.0.8.eb
  • SUCCESS bzip2-1.0.8-GCCcore-9.3.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-13.2.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-12.3.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-11.2.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-10.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/2af450a116c96aa86a65ebe4c81a4355 for a full test report.

@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in bzip2.py replace run_cmd with run_shell_cmd in custom easyblock for ADF (bzip2.py) Jan 29, 2024
@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in custom easyblock for ADF (bzip2.py) replace run_cmd with run_shell_cmd in custom easyblock for bzip2 (bzip2.py) Jan 29, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 29, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH="5.0.x"
EB_ARGS="bzip2-1.0.8.eb bzip2-1.0.8-GCCcore-11.3.0.eb bzip2-1.0.8-GCCcore-12.2.0.eb --installpath /tmp/$USER/pr3101"

boegel
boegel approved these changes Jan 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 29, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3101 EB_ARGS="bzip2-1.0.8.eb bzip2-1.0.8-GCCcore-11.3.0.eb bzip2-1.0.8-GCCcore-12.2.0.eb --installpath /tmp/$USER/pr3101" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3101 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3509

Test results coming soon (I hope)...

Details

- notification for comment with ID 1915096802 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 29, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS bzip2-1.0.8.eb
  • SUCCESS bzip2-1.0.8-GCCcore-11.3.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-12.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/37f15fcf85ae741b6d65c55688dbab65 for a full test report.

@boegel boegel merged commit 38bbbbd into easybuilders:5.0.x Jan 29, 2024
@branfosj branfosj deleted the 20240128172051_new_pr_bzip2 branch January 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot