Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for CP2K (cp2k.py)#3113

Merged
jfgrimm merged 5 commits intoeasybuilders:5.0.xfrom
branfosj:20240129200220_new_pr_cp2k
Feb 9, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for CP2K (cp2k.py)#3113
jfgrimm merged 5 commits intoeasybuilders:5.0.xfrom
branfosj:20240129200220_new_pr_cp2k

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 29, 2024

(created using eb --new-pr)

  • No use of EB_CP2K in easyconfigs or blocks

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Libint-2.7.2-GCC-11.3.0-lmax-6-cp2k.eb
  • SUCCESS libvori-220621-GCCcore-11.3.0.eb
  • SUCCESS CP2K-9.1-foss-2022a.eb

Build succeeded for 3 out of 3 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/91236048e3678b6db418d717130fe2c1 for a full test report.

Comment thread easybuild/easyblocks/c/cp2k.py Outdated
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 9, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS CP2K-9.1-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/c2558380a474378bb5d996db11cb3b76 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit ad3f3ee into easybuilders:5.0.x Feb 9, 2024
@branfosj branfosj deleted the 20240129200220_new_pr_cp2k branch February 9, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants