Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for Java (java.py)#3120

Merged
jfgrimm merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240131094650_new_pr_java
Feb 1, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for Java (java.py)#3120
jfgrimm merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240131094650_new_pr_java

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 31, 2024

(created using eb --new-pr)

  • No use of EB_Java in easyconfigs or blocks

The main items here are around rpath handling.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 1, 2024

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS Java-8.362.eb
  • SUCCESS Java-11.0.20.eb
  • SUCCESS Java-13.0.2.eb
  • SUCCESS Java-17.0.6.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node038.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/22d18b88704002e57418d417b20fb503 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit dcd646c into easybuilders:5.0.x Feb 1, 2024
@branfosj branfosj deleted the 20240131094650_new_pr_java branch March 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants