Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for impi (impi.py)#3124

Merged
jfgrimm merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240131182216_new_pr_impi
Feb 9, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for impi (impi.py)#3124
jfgrimm merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240131182216_new_pr_impi

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 31, 2024

(created using eb --new-pr)

  • No use of EB_impi in easyconfigs
  • EB_impi inherited in generic/systemmpi.py

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS impi-2021.9.0-intel-compilers-2023.1.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/cd4e86ca0c74ec1718b0da75084a5df8 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit 367bea9 into easybuilders:5.0.x Feb 9, 2024
@branfosj branfosj deleted the 20240131182216_new_pr_impi branch February 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants